fix(ci): make filename changes change file hash in docker cache #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright, now this worked - so file names are now taken into account in the hash for backend We should roll this out to the other cache builds as well. |
corneliusroemer
force-pushed
the
fix-hash-filename
branch
from
40b1515
to
803780b
Compare
corneliusroemer
changed the title
theosanderson
approved these changes
Sep 18, 2024
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially resolves #2838
Previously the way we calculated hashes only used file content - not file names, which can matter.
Now we create and add a hash of all relevant file names and use that as input for the docker cache hash.
This change needs to be mirrored to all workflows that use this caching strategy to avoid filename renames not changing the hash.