Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest): Raise ingest error if we ever have multiple loculus accession for one insdc accession in loculus #2844

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

anna-parker
Copy link
Contributor

@anna-parker anna-parker commented Sep 19, 2024

resolves #

preview URL: https://ingest-error.loculus.org/

Summary

Raise an error in ingest if we ever have multiple loculus accession for one insdc accession loculus.

This si still too late (i.e. the duplication has already occured) but will warn us and hopefully make the logs a bit cleaner.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@theosanderson theosanderson added the preview Triggers a deployment to argocd label Sep 19, 2024
@anna-parker anna-parker changed the title Raise error if we ever have multiple loculus accession in ingest feat(ingest): Raise ingest error if we ever have multiple loculus accession for one insdc accession in loculus Sep 19, 2024
@anna-parker
Copy link
Contributor Author

I see this in the backend logs:

2024-09-19 12:19:05,671 INFO [http-nio-8079-exec-9] [west-nile] - org.loculus.backend.log.ResponseLogger: GET https://backend-ingest-error.loculus.org/west-nile/get-original-metadata - Responding with status 200
2024-09-19 12:19:07,951 INFO [http-nio-8079-exec-4] [ebola-zaire] - org.loculus.backend.log.ResponseLogger: GET https://backend-ingest-error.loculus.org/ebola-zaire/get-original-metadata - Responding with status 200
2024-09-19 12:19:46,190 INFO [http-nio-8079-exec-3] [west-nile] - org.loculus.backend.log.ResponseLogger: GET https://backend-ingest-error.loculus.org/west-nile/get-original-metadata - Responding with status 200

but I only see one request from west-nile ingest

@anna-parker anna-parker merged commit aff8472 into main Sep 19, 2024
15 checks passed
@anna-parker anna-parker deleted the ingest_error branch September 19, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants