Add INSDC accession to results of ena submission and upload to backend. #2845
+277
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-parker
commented
Sep 22, 2024
| ena_submission_url: https://wwwdev.ebi.ac.uk/ena/submit/drop-box/submit # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production | ||
| github_url: https://raw.githubusercontent.com/pathoplexus/ena-submission/main/test/approved_ena_submission_list.json # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production | ||
| ena_reports_service_url: https://wwwdev.ebi.ac.uk/ena/submit/report # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production | ||
| submit_to_ena_prod: False # TODO(https://github.com/loculus-project/loculus/issues/2425): update in production |
There was a problem hiding this comment.
In a later PR I will add a corresponding field in the values.yaml and update the ena-submission template to make sure this can be set to true via the values.yaml for Pathoplexus. In the same PR I will add a github workflow to prevent us setting this to true for a preview instance without an override as a safety mechanism.
anna-parker
force-pushed
the
add_insdcAccession
branch
from
cdf855d
to
008328e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL:
Summary
--testflag (determines if ENA dev or prod is used) that is set at config level to make code clearer.Screenshot
PR Checklist