Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make start_dev.sh readable/maintainable by breaking lines #2853

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: make start_dev.sh readable/maintainable by breaking lines #2853

merged 1 commit into from
Sep 20, 2024

Conversation

corneliusroemer
Copy link
Contributor

@corneliusroemer corneliusroemer commented Sep 20, 2024 •
edited
Loading

Now it can actually be edited and viewed properly in less/vim:

Brave Browser 2024-09-20 14 41 59

@corneliusroemer corneliusroemer changed the title chore: make start_dev.sh maintainable by breaking lines chore: make start_dev.sh readable/maintainable by breaking lines Sep 20, 2024
@corneliusroemer corneliusroemer added the review please PR waiting for final review label Sep 20, 2024
@corneliusroemer corneliusroemer enabled auto-merge (squash) September 20, 2024 12:43
theosanderson
theosanderson approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@theosanderson theosanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong feelings from me on what's better - a copyable one liner can be good - but happy to go with your preference

@corneliusroemer corneliusroemer merged commit d38457b into main Sep 20, 2024
17 checks passed
@corneliusroemer corneliusroemer deleted the maintainable-script branch September 20, 2024 12:52
@corneliusroemer
Copy link
Contributor Author

there's a one liner: ./start_dev.sh :)

@theosanderson
Copy link
Member

Well you can't adjust that one liner to do temporarily configure something differently without writing to the file system

@github-actions github-actions bot mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theosanderson theosanderson theosanderson approved these changes

Assignees
No one assigned
Labels
review please PR waiting for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneliusroemer @theosanderson