Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): upgrade to astro 4 #660

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

TobiasKampmann
Copy link
Contributor

Upgrade to astro 4

regress of our msw/node issue

@TobiasKampmann TobiasKampmann linked an issue Dec 13, 2023 that may be closed by this pull request
@TobiasKampmann TobiasKampmann force-pushed the 644-update-to-astro-4 branch 4 times, most recently from 1103d7e to 5d6b315 Compare December 13, 2023 16:54
@JonasKellerer
Copy link
Contributor

The dev mode works for me if I set exclude: ['fsevents', 'msw/node', 'msw'], in astro.config.mjs
But I dont know why the other one fails. The logs give me the error that
`node:internal/modules/esm/resolve:844
throw new ERR_MODULE_NOT_FOUND(packageName, fileURLToPath(base), null);
^

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'cookie' imported from /app/dist/server/entry.mjs
at packageResolve (node:internal/modules/esm/resolve:844:9)
at moduleResolve (node:internal/modules/esm/resolve:901:20)
at defaultResolve (node:internal/modules/esm/resolve:1121:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
at ModuleWrap. (node:internal/modules/esm/module_job:85:39)
at link (node:internal/modules/esm/module_job:84:36) {
code: 'ERR_MODULE_NOT_FOUND'
}
`
Something with the cookie import you added?

@JonasKellerer
Copy link
Contributor

It seems that the dev modus does not work on main as well? I'll try my fix there and push it.

@TobiasKampmann
Copy link
Contributor Author

the website dont start -> e2e fail

@TobiasKampmann TobiasKampmann marked this pull request as ready for review January 9, 2024 12:24
@TobiasKampmann TobiasKampmann added the preview Triggers a deployment to argocd label Jan 9, 2024
@TobiasKampmann TobiasKampmann merged commit c2aecca into main Jan 9, 2024
11 checks passed
@TobiasKampmann TobiasKampmann deleted the 644-update-to-astro-4 branch January 9, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Astro 4
3 participants