Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

670 adapt submit flow #699

Merged
merged 1 commit into from
Dec 20, 2023
Merged

670 adapt submit flow #699

merged 1 commit into from
Dec 20, 2023

Conversation

TobiasKampmann
Copy link
Contributor

@TobiasKampmann TobiasKampmann commented Dec 19, 2023

Only submit and revise are validated so that the submitter is member of the group owning the sequence.

Since uploading can take some time, the validation is the first step.

Other endpoints will be validated via the existing SubmissionPreconditionValidator in the next ticket.

@TobiasKampmann TobiasKampmann linked an issue Dec 19, 2023 that may be closed by this pull request
@TobiasKampmann TobiasKampmann changed the base branch from main to 667-endpoint-delete-user-from-group December 19, 2023 17:26
@TobiasKampmann TobiasKampmann force-pushed the 670-adapt-submit-flow branch 2 times, most recently from 2d8d1d9 to a13c3aa Compare December 19, 2023 18:06
@TobiasKampmann TobiasKampmann marked this pull request as ready for review December 19, 2023 18:07
@TobiasKampmann TobiasKampmann force-pushed the 670-adapt-submit-flow branch 2 times, most recently from b890c79 to b82a731 Compare December 19, 2023 19:01
@TobiasKampmann TobiasKampmann marked this pull request as draft December 19, 2023 19:39
@TobiasKampmann TobiasKampmann force-pushed the 667-endpoint-delete-user-from-group branch from 4247302 to 135b19a Compare December 20, 2023 10:18
@TobiasKampmann TobiasKampmann force-pushed the 670-adapt-submit-flow branch 2 times, most recently from 0f85916 to 319bfc8 Compare December 20, 2023 10:53
Base automatically changed from 667-endpoint-delete-user-from-group to main December 20, 2023 10:53
@TobiasKampmann TobiasKampmann force-pushed the 670-adapt-submit-flow branch 3 times, most recently from b33162b to 75b9342 Compare December 20, 2023 11:28
@TobiasKampmann TobiasKampmann marked this pull request as ready for review December 20, 2023 11:50
@TobiasKampmann
Copy link
Contributor Author

squash before merge

Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TobiasKampmann TobiasKampmann merged commit 6a0de77 into main Dec 20, 2023
11 checks passed
@TobiasKampmann TobiasKampmann deleted the 670-adapt-submit-flow branch December 20, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapt submit flow
2 participants