-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
670 adapt submit flow #699
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
from
December 19, 2023 17:25
a3cee02
to
c7b47d7
Compare
TobiasKampmann
changed the base branch from
main
to
667-endpoint-delete-user-from-group
December 19, 2023 17:26
TobiasKampmann
commented
Dec 19, 2023
backend/src/main/kotlin/org/pathoplexus/backend/service/submission/DatabaseService.kt
Show resolved
Hide resolved
TobiasKampmann
commented
Dec 19, 2023
backend/src/test/kotlin/org/pathoplexus/backend/controller/EndpointTestExtension.kt
Show resolved
Hide resolved
TobiasKampmann
commented
Dec 19, 2023
...kotlin/org/pathoplexus/backend/controller/groupmanagement/GroupManagementControllerClient.kt
Show resolved
Hide resolved
TobiasKampmann
commented
Dec 19, 2023
...t/kotlin/org/pathoplexus/backend/controller/groupmanagement/GroupManagementControllerTest.kt
Show resolved
Hide resolved
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
2 times, most recently
from
December 19, 2023 18:06
2d8d1d9
to
a13c3aa
Compare
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
2 times, most recently
from
December 19, 2023 19:01
b890c79
to
b82a731
Compare
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
from
December 19, 2023 21:33
b82a731
to
273c212
Compare
TobiasKampmann
force-pushed
the
667-endpoint-delete-user-from-group
branch
from
December 20, 2023 10:18
4247302
to
135b19a
Compare
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
2 times, most recently
from
December 20, 2023 10:53
0f85916
to
319bfc8
Compare
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
3 times, most recently
from
December 20, 2023 11:28
b33162b
to
75b9342
Compare
squash before merge |
fengelniederhammer
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...t/kotlin/org/pathoplexus/backend/controller/groupmanagement/GroupManagementControllerTest.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/org/pathoplexus/backend/controller/groupmanagement/GroupManagementControllerTest.kt
Outdated
Show resolved
Hide resolved
backend/src/test/kotlin/org/pathoplexus/backend/controller/submission/ReviseEndpointTest.kt
Outdated
Show resolved
Hide resolved
…ubmitter is part of it.
TobiasKampmann
force-pushed
the
670-adapt-submit-flow
branch
from
December 20, 2023 15:19
6a55b38
to
4fb2ac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only submit and revise are validated so that the submitter is member of the group owning the sequence.
Since uploading can take some time, the validation is the first step.
Other endpoints will be validated via the existing SubmissionPreconditionValidator in the next ticket.