Fix for #43 #59
Open
Fix for #43 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,12 +52,16 @@ class LocomotorActionServer | |||
| void publishFeedback(const locomotor_msgs::NavigationState& nav_state); | |||
| void completeNavigation(); | |||
| void failNavigation(const locomotor_msgs::ResultCode& result_code); | |||
|
|
|||
| // Note: This is a separate method so as not to change the previous constructor parameter list | |||
| void setPremptionCallback(PreemptionCallback cb) { preemption_cb_ = cb; } | |||
There was a problem hiding this comment.
I'd recommend just having a virtual void onPreemption() {} method that the user can override.
There was a problem hiding this comment.
In this one. Rather than setting a callback functor, you can just let the user override the onPreemption method if they want to trigger some callback. These 2 actions will have equal output.
|
Hello, what is the status of this? @SteveMacenski, if @DLu does not have the time i can integrate the changes you requested into a fork and create a new merge request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #43.
@cf-zhang Does this work for you?