fix(ios): use RNSLifecycleListenerProtocol for screen dismiss detection #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RNSLifecycleListenerProtocol to react-native-screens patch - TrueSheetViewController conforms to protocol to receive screen lifecycle events - Rename viewControllerDidDetectPresenterDismiss to viewControllerDidDetectScreenDismiss - Remove notification-based approach in favor of protocol-based approach
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
🚀 This pull request is included in v3.7.1. See Release 3.7.1 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #400. Improves screen dismiss detection on iOS by using
RNSLifecycleListenerProtocolinstead of NSNotification observers.New react-native-screens PR: software-mansion/react-native-screens#3527
Changes
RNSLifecycleListenerProtocolreact-native-screensto expose lifecycle events to presented controllersType of Change
Test Plan
goBack()button on TestScreen in example appafter.mov
Checklist