refactor(ios): detect screen unmount via C++ EventDispatcher #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass EventDispatcher from ComponentDescriptor through State to native view - Listen for topWillDisappear events to detect when presenter screen unmounts - Capture presenter screen tag and controller at presentation time - Distinguish navigation pop from modal dismiss by checking nav stack - Dismiss sheet when its presenter screen is being popped This replaces RNSLifecycleListenerProtocol per react-native-screens feedback. See: software-mansion/react-native-screens#3527
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks
Owner
Author
|
🚀 This pull request is included in v3.7.4-beta.0. See Release 3.7.4-beta.0 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
RNSLifecycleListenerProtocolwith a C++ EventDispatcher-based solution for detecting when a presenting screen unmounts while a sheet is presented.Context: react-native-screens maintainers want to avoid component-specific integrations. See: software-mansion/react-native-screens#3527 (review)
How it works
EventDispatcherthrough state viaComponentDescriptor::adopt()RNScreensEventObserverto listen fortopWillDisappearevents_presenterScreenTag,_presenterScreenController)topWillDisappearfires, check if the screen is no longer the top view controller (pushed or popped)Files changed
C++ (iOS-only):
TrueSheetViewState- AddedeventDispatcher_memberTrueSheetViewShadowNode- AddedsetEventDispatcher()TrueSheetViewComponentDescriptor- Passes dispatcher inadopt()iOS:
RNScreensEventObserver- New observer class for screen lifecycle eventsTrueSheetView.mm- Integrates observer, typed delegate for direct window access_parentModalTagtracking - simplified detection usingtopViewControllercheckType of Change
Test Plan
Checklist