Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose VCluster Status Fields as printer columns #100

Conversation

whiskeyjimbo
Copy link

This PR exposes the already set status values and adds some validation and documentation.

changes:

  • Add kubebuilder validation for VCluster status fields
    • Default values for Ready and Initialized fields (false)
    • Enum validation for Phase field
  • Add additional printer columns for better kubectl get vluster output:
    • Version
    • Ready
    • Phase
    • Message
    • Age

@whiskeyjimbo whiskeyjimbo changed the title Expose VCluster Status Fields and Documentation Expose VCluster Status Fields as printer columns Jan 27, 2025
@johannesfrey
Copy link
Contributor

Thx @whiskeyjimbo

There currently is a PR that allows the helm chart version to be empty, which will result in pulling the latest stable release. I guess looking at .spec.helmRelease.chart.version is good for now, though this would display an empty string when nothing is set by the user.

I guess I'll create a follow-up PR to retrieve the latest release tag and put that as a field under Status.

@johannesfrey johannesfrey force-pushed the update-vcluster-status-for-better-info branch from 650ca65 to f7175b8 Compare February 3, 2025 08:55
@johannesfrey johannesfrey merged commit fddb777 into loft-sh:main Feb 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants