Skip to content

Support lifecycle hooks in devcontainer features #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support lifecycle hooks in devcontainer features #1881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions pkg/devcontainer/config/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,7 @@ type FeatureConfig struct {
// Container environment variables.
ContainerEnv map[string]string `json:"containerEnv,omitempty"`

// Tool-specific configuration. Each tool should use a JSON object subproperty with a unique name to group its customizations.
Customizations map[string]interface{} `json:"customizations,omitempty"`
DevContainerActions `json:",inline"`

// Origin is the path where the feature was loaded from
Origin string `json:"-"`
Expand Down
7 changes: 6 additions & 1 deletion pkg/devcontainer/metadata/metadata.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ func FeatureConfigToImageMetadata(feature *config.FeatureConfig) *config.ImageMe
return &config.ImageMetadata{
Entrypoint: feature.Entrypoint,
DevContainerActions: config.DevContainerActions{
Customizations: feature.Customizations,
OnCreateCommand: feature.OnCreateCommand,
UpdateContentCommand: feature.UpdateContentCommand,
PostCreateCommand: feature.PostCreateCommand,
PostStartCommand: feature.PostStartCommand,
PostAttachCommand: feature.PostAttachCommand,
Customizations: feature.Customizations,
},
NonComposeBase: config.NonComposeBase{
Mounts: feature.Mounts,
Expand Down