Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work around for #209 #210

Merged
merged 1 commit into from
Jan 3, 2024
Merged

work around for #209 #210

merged 1 commit into from
Jan 3, 2024

Conversation

vanowm
Copy link

@vanowm vanowm commented Dec 29, 2023

This patch forcibly merging default settings into global config. It doesn't overwrite any modified settings.
Would be nice add some cleanup on extension disable/uninstall, but I couldn't find a way to do so.

Fix for #209

@vanowm vanowm changed the title work around for #209 work around for #210 Dec 29, 2023
@vanowm vanowm changed the title work around for #210 work around for #209 Dec 29, 2023
@loganch
Copy link
Owner

loganch commented Dec 31, 2023

Nice catch/find, you're not able to save the state of global config before changes and then undo the changes through the deactivate() function in extension.js?

@vanowm
Copy link
Author

vanowm commented Dec 31, 2023

Didn't know about that function. How do we test it though? (I mean besides directly calling the function) The extension is not in the list of installed extensions, so I can't disable or uninstall it...

@vanowm
Copy link
Author

vanowm commented Jan 1, 2024

It seems not possible within this function microsoft/vscode/issues/105484

@loganch
Copy link
Owner

loganch commented Jan 3, 2024

Yikes, that's unfortunate.

@loganch loganch merged commit 38b01c5 into loganch:master Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants