Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential deadlock? #113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

potential deadlock? #113

wants to merge 3 commits into from

Commits on Jul 23, 2024

  1. rename functions for consistency 

    We find the same pattern with buffer_log and flush: a sync version and a
version distributed to a thread pool.
This commit harmonizes namings:
- schedule_flush_sync => flush_with_lock
- try_lock_and_do_flush_request => flush_sync
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0cb6107 View commit details
    Browse the repository at this point in the history

  2. add one test proving deadlock 

    when logging and closing simultaneously the code enters a deadlock.
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cb81745 View commit details
    Browse the repository at this point in the history

  3. remove risk of deadlock in close function 

    The previous version was prone to a deadlock (see added test in previous
commit)
    @sebdiem
    sebdiem committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    26442d7 View commit details
    Browse the repository at this point in the history