Skip to content

fix(lm-logs,argus): fluentd CM typo and misc #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dwebsterhbc
Copy link
Contributor

  • fluentd ConfigMap "seperator" typo could cause issues
  • DaemonSet tpl filename and argus description trivial, but..
  • Bump argus chart to 11.1.1
  • Bump lm-logs chart to 0.6.1

* fluentd ConfigMap "seperator" typo could cause issues
* DaemonSet tpl filename and argus description trivial, but..
* Bump argus chart to 11.1.1
* Bump lm-logs chart to 0.6.1
@dwebsterhbc
Copy link
Contributor Author

@lmvaibhavk - closed off the old PR #168 which I forgot to sync from upstream, so cleaner to do new one.

@lmvaibhavk
Copy link
Collaborator

LGTM.
@choudharypooja @shubhashri12 Can you please review as you are the code owners for individual charts?

@dwebsterhbc
Copy link
Contributor Author

@choudharypooja @lmshubhashri - Please address the broken check.

@lmshubhashri
Copy link
Contributor

@choudharypooja @lmshubhashri - Please address the broken check.

Hi @dwebsterhbc, we are good to merge the PR. I am doing it on your behalf since there is a build failure of github-tokens.

@lmshubhashri lmshubhashri merged commit 8c8f942 into logicmonitor:main Jan 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants