Skip to content

Fix time column judgment #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
logicoffee merged 1 commit into from
Jan 21, 2026
Merged

Fix time column judgment #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/analytics_query_analyzer/timespan_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,16 @@ def is_time_column(
column_type = self.schema[project][dataset][table][column_root]
except KeyError:
return False
return str(column_type).lower() in {"datetime", "date", "timestamp"}
normalized = str(column_type).lower()
if normalized in {
"datetime",
"date",
"timestamp",
"timestamp without time zone",
"timestamp with time zone",
}:
return True
return False

@staticmethod
def merge_bounds_and(
Expand Down