Test/data availability and integrity #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disperse_data - get_range
- add disperse_data
- use oneliner for volumes
- test_da_sampling_determines_data_presence
fbarbu15
approved these changes
Jan 27, 2025
| from src.steps.da import StepsDataAvailability | ||
| from src.test_data import DATA_TO_DISPERSE | ||
|
|
||
| logger = get_custom_logger(__name__) |
| # Use received blob data to reconstruct the original data | ||
| # nomos-cli reconstruct command required | ||
| reconstructed_data = [] | ||
| assert DATA_TO_DISPERSE[0] == bytes(reconstructed_data).decode("utf-8") |
There was a problem hiding this comment.
but bytes(reconstructed_data).decode("utf-8") is empty string and DATA_TO_DISPERSE[0] should be "Hello World!"
what are we asserting here?
There was a problem hiding this comment.
Yes, the nomos-cli should be called to reconstruct the data from received blobs. PR in nomos-node repo logos-co/nomos-node#994. I would assume nomos-cli as our "first to go" verification tool. We might think about being independent, with our own tooling, however this would come at certain cost. We can discuss more during meeting.
There was a problem hiding this comment.
ok, but now the assert will not pass, right?
There was a problem hiding this comment.
Tests skipped at b4d32df
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Set of tests to cover data availability and integrity.
Issues reported: