Skip to content

Commit

Permalink
fix(StakeManager): fix finalizeEpoch to use last epoch epochEnd and a…
Browse files Browse the repository at this point in the history 
…dd tests to catch error
  • Loading branch information
@3esmit
3esmit committed Sep 25, 2024
1 parent 4a545a0 commit 057aee1
Show file tree
Hide file tree
Showing 4 changed files with 167 additions and 110 deletions.
72 changes: 36 additions & 36 deletions .gas-report
View file
Original file line number Diff line number Diff line change
@@ -1,37 +1,37 @@
| contracts/StakeManager.sol:StakeManager contract | | | | | |
|--------------------------------------------------|-----------------|--------|--------|--------|---------|
| Deployment Cost | Deployment Size | | | | |
| 2931383 | 14953 | | | | |
| 2469345 | 12797 | | | | |
| Function Name | min | avg | median | max | # calls |
| EPOCH_SIZE | 307 | 307 | 307 | 307 | 1452 |
| EPOCH_SIZE | 307 | 307 | 307 | 307 | 1476 |
| MAX_BOOST | 285 | 285 | 285 | 285 | 637 |
| MAX_LOCKUP_PERIOD | 361 | 361 | 361 | 361 | 4 |
| MIN_LOCKUP_PERIOD | 287 | 287 | 287 | 287 | 12 |
| YEAR | 263 | 263 | 263 | 263 | 637 |
| accounts | 1597 | 1597 | 1597 | 1597 | 144321 |
| accounts | 1561 | 1561 | 1561 | 1561 | 144375 |
| calculateMPToMint | 740 | 740 | 740 | 740 | 1276 |
| currentEpoch | 406 | 1691 | 2406 | 2406 | 28 |
| epochEnd | 627 | 627 | 627 | 4627 | 23603 |
| epochReward | 1403 | 2903 | 1403 | 5903 | 3 |
| executeAccount | 28897 | 76117 | 77904 | 171987 | 141882 |
| executeEpoch | 23436 | 146208 | 147383 | 204283 | 23542 |
| isVault | 540 | 927 | 540 | 2540 | 671 |
| currentEpoch | 406 | 1188 | 406 | 2406 | 46 |
| epochEnd | 627 | 627 | 627 | 4627 | 23648 |
| epochReward | 1391 | 2891 | 1391 | 5891 | 3 |
| executeAccount | 30958 | 76171 | 77953 | 240555 | 141954 |
| executeEpoch | 23424 | 145441 | 146624 | 203524 | 23574 |
| isVault | 540 | 939 | 540 | 2540 | 676 |
| lock | 23840 | 23840 | 23840 | 23840 | 1 |
| migrateTo | 23869 | 23875 | 23875 | 23881 | 2 |
| migration | 439 | 1439 | 1439 | 2439 | 4 |
| migrationInitialize | 24602 | 24602 | 24602 | 24602 | 1 |
| owner | 2432 | 2432 | 2432 | 2432 | 13 |
| pendingMPToBeMinted | 364 | 364 | 364 | 364 | 46448 |
| migration | 415 | 1415 | 1415 | 2415 | 4 |
| migrationInitialize | 24578 | 24578 | 24578 | 24578 | 1 |
| owner | 2408 | 2408 | 2408 | 2408 | 13 |
| pendingMPToBeMinted | 364 | 364 | 364 | 364 | 46466 |
| pendingReward | 364 | 1398 | 2364 | 2364 | 29 |
| previousManager | 275 | 275 | 275 | 275 | 13 |
| setVault | 46239 | 46239 | 46239 | 46239 | 130 |
| previousManager | 263 | 263 | 263 | 263 | 13 |
| setVault | 46227 | 46227 | 46227 | 46227 | 135 |
| stake | 23983 | 23983 | 23983 | 23983 | 1 |
| stakeRewardEstimate | 436 | 2269 | 2436 | 2436 | 12 |
| stakedToken | 273 | 273 | 273 | 273 | 687 |
| startMigration | 108037 | 108045 | 108049 | 108049 | 3 |
| stakeRewardEstimate | 412 | 2294 | 2412 | 2412 | 17 |
| stakedToken | 261 | 261 | 261 | 261 | 692 |
| startMigration | 107990 | 107998 | 108002 | 108002 | 3 |
| totalSupply | 740 | 1921 | 2740 | 2740 | 22 |
| totalSupplyBalance | 385 | 1785 | 2385 | 2385 | 20 |
| totalSupplyMP | 385 | 385 | 385 | 2385 | 46469 |
| totalSupplyMP | 385 | 385 | 385 | 2385 | 46487 |
| unstake | 23819 | 23819 | 23819 | 23819 | 1 |


Expand All @@ -40,7 +40,7 @@
| Deployment Cost | Deployment Size | | | | |
| 0 | 0 | | | | |
| Function Name | min | avg | median | max | # calls |
| getExpiredMP | 2427 | 2427 | 2427 | 2427 | 23598 |
| getExpiredMP | 2427 | 2427 | 2427 | 2427 | 23645 |
| transferOwnership | 28533 | 28533 | 28533 | 28533 | 1 |


Expand All @@ -49,21 +49,21 @@
| Deployment Cost | Deployment Size | | | | |
| 0 | 0 | | | | |
| Function Name | min | avg | median | max | # calls |
| acceptMigration | 35258 | 35258 | 35258 | 35258 | 2 |
| leave | 35244 | 35244 | 35244 | 35244 | 1 |
| lock | 45192 | 73900 | 66395 | 158442 | 7 |
| owner | 362 | 362 | 362 | 362 | 670 |
| stake | 27265 | 283296 | 267703 | 353862 | 675 |
| acceptMigration | 35246 | 35246 | 35246 | 35246 | 2 |
| leave | 35232 | 35232 | 35232 | 35232 | 1 |
| lock | 45376 | 99625 | 66468 | 193557 | 7 |
| owner | 362 | 362 | 362 | 362 | 675 |
| stake | 27265 | 283876 | 267740 | 353899 | 680 |
| stakedToken | 212 | 212 | 212 | 212 | 2 |
| unstake | 42163 | 92598 | 80285 | 207456 | 11 |
| unstake | 42248 | 92540 | 80334 | 206828 | 11 |


| contracts/VaultFactory.sol:VaultFactory contract | | | | | |
|--------------------------------------------------|-----------------|--------|--------|--------|---------|
| Deployment Cost | Deployment Size | | | | |
| 0 | 0 | | | | |
| Function Name | min | avg | median | max | # calls |
| createVault | 696531 | 696531 | 696531 | 696531 | 674 |
| createVault | 696519 | 696519 | 696519 | 696519 | 679 |
| setStakeManager | 23710 | 26669 | 26076 | 30222 | 3 |
| stakeManager | 368 | 1868 | 2368 | 2368 | 4 |

Expand All @@ -73,32 +73,32 @@
| Deployment Cost | Deployment Size | | | | |
| 0 | 0 | | | | |
| Function Name | min | avg | median | max | # calls |
| approve | 46175 | 46237 | 46199 | 46367 | 670 |
| balanceOf | 561 | 2108 | 2561 | 2561 | 30693 |
| approve | 46175 | 46236 | 46199 | 46367 | 675 |
| balanceOf | 561 | 2108 | 2561 | 2561 | 30755 |


| script/Deploy.s.sol:Deploy contract | | | | | |
|-------------------------------------|-----------------|---------|---------|---------|---------|
| Deployment Cost | Deployment Size | | | | |
| 6532373 | 31450 | | | | |
| 6070229 | 29294 | | | | |
| Function Name | min | avg | median | max | # calls |
| run | 5752636 | 5752636 | 5752636 | 5752636 | 56 |
| run | 5320405 | 5320405 | 5320405 | 5320405 | 61 |


| script/DeployMigrationStakeManager.s.sol:DeployMigrationStakeManager contract | | | | | |
|-------------------------------------------------------------------------------|-----------------|---------|---------|---------|---------|
| Deployment Cost | Deployment Size | | | | |
| 3695815 | 18218 | | | | |
| 3233781 | 16062 | | | | |
| Function Name | min | avg | median | max | # calls |
| run | 2738306 | 2738306 | 2738306 | 2738306 | 9 |
| run | 2306051 | 2306051 | 2306051 | 2306051 | 14 |


| script/DeploymentConfig.s.sol:DeploymentConfig contract | | | | | |
|---------------------------------------------------------|-----------------|-----|--------|-----|---------|
| Deployment Cost | Deployment Size | | | | |
| 0 | 0 | | | | |
| Function Name | min | avg | median | max | # calls |
| activeNetworkConfig | 455 | 455 | 455 | 455 | 112 |
| activeNetworkConfig | 455 | 455 | 455 | 455 | 122 |


| test/mocks/BrokenERC20.s.sol:BrokenERC20 contract | | | | | |
Expand All @@ -113,9 +113,9 @@
| test/script/DeployBroken.s.sol:DeployBroken contract | | | | | |
|------------------------------------------------------|-----------------|---------|---------|---------|---------|
| Deployment Cost | Deployment Size | | | | |
| 5217091 | 25248 | | | | |
| 4754997 | 23092 | | | | |
| Function Name | min | avg | median | max | # calls |
| run | 4592458 | 4592458 | 4592458 | 4592458 | 1 |
| run | 4160227 | 4160227 | 4160227 | 4160227 | 1 |



Expand Down
Loading

0 comments on commit 057aee1

Please sign in to comment.