Adding lock limit of 4 years #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x-r4bbit
reviewed
Sep 27, 2023
| @@ -88,6 +88,7 @@ contract StakeManager is Ownable { | |||
| function lock(uint256 _time) external onlyVault { | |||
| Account storage account = accounts[msg.sender]; | |||
| processAccount(account, currentEpoch); | |||
| require(_time < 209 weeks, "Cannot lock for more than 4 years"); | |||
There was a problem hiding this comment.
Probably better to have this stored as a constant and use that instead.
Something like:
uint256 constant 4_YEARS = 209 weeks;
While it won't make such a huge difference, you generally want to avoid using "magic" numbers without semantic value.
There was a problem hiding this comment.
uint256 constant MAX_LOCK_TIME = 209 weeks;
There was a problem hiding this comment.
Yes, makes sense.
|
Closing this in favour of #39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.