Add drop_error_types config option to not retry after certain error types #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
reviewed
Oct 1, 2025
estolfo
force-pushed
the
drop-error-types
branch
from
26e7204 to
e8afdf4
Compare
estolfo
commented
Oct 2, 2025
jsvd
reviewed
Oct 2, 2025
jsvd
reviewed
Oct 2, 2025
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
estolfo
force-pushed
the
drop-error-types
branch
from
3595ff6 to
bc41010
Compare
jsvd
requested changes
Oct 6, 2025
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option
drop_error_typesthat allows a user to set a list of error types for which a failed bulk request should not be retried and the events should be dropped. The events are not added to the DLQ. A warn message is logged, if the error type is not listed in the config optionsilence_errors_in_log.Closes #1225