Use docker-setup.sh from upstream .ci repo (#1227) #1229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom docker-setup.sh script here is not materially different from the shared script in the `.ci` repository. The only difference were pulling and starting the elasticsearch image. This should not affect CI materially and the consistency gain we get using the same `docker-setup.sh` file everywhere is preferrable to having a slightly different script here.
donoghuc
force-pushed
the
backport-ci-script-removal
branch
from
136d87a to
7684d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom docker-setup.sh script here is not materially different from the shared script in the
.cirepository. The only difference were pulling and starting the elasticsearch image. This should not affect CI materially and the consistency gain we get using the samedocker-setup.shfile everywhere is preferrable to having a slightly different script here.Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/