Open
Conversation
Add @typescript/native-preview for faster type checking: - check-types: runs tsgo --noEmit - check-types:tsc: runs tsc --noEmit lint script remains on tsc since tsgo is preview software.
casamitjana
requested review from
a team,
CarlosGamero,
drdaemos and
kibertoad
as code owners
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Package Configuration package.json |
Added npm scripts: check-types (tsgo --noEmit) and check-types:tsc (tsc --noEmit). Added devDependency: @typescript/native-preview@^7.0.0-dev.20260122.3 |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check | PR description is well-structured but missing required checklist items from the template. | Complete the required checklist by selecting a release label (major/minor/patch/skip-release) and confirming documentation and test updates were addressed or not necessary. |
✅ Passed checks (2 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check | ✅ Passed | The title clearly summarizes the main change: adding tsgo type checker alongside tsc. It is concise, specific, and directly related to the primary objective of the pull request. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
Comment @coderabbitai help to get the list of available commands and usage tips.
kibertoad
reviewed
Jan 22, 2026
| }, | ||
| "scripts": { | ||
| "build": "tsup", | ||
| "check-types": "tsgo --noEmit", |
Collaborator
There was a problem hiding this comment.
should we start using it in CI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@typescript/native-previewdev dependency for faster type checkingcheck-typesscript (tsgo --noEmit)check-types:tscscript (tsc --noEmit)lintscript remains on tsc since tsgo is preview softwareMeasurements
npm run check-types(tsgo)npm run check-types:tsc(tsc)tsgo is ~40% faster on this codebase.
Test plan
npm installsucceedsnpm run check-typespassesnpm run check-types:tscpassesSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.