Use fastapi._compat's ModelField if pydantic version is 2 #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elField in pydantic v1 is not there in v2 anymore.
|
I hope it will eventually be merged, because outdated pedantic makes whole library unusable (together with stupid limitation of caching only GET requests) |
|
Hey, how is this PR supposed to work? I merged your changes locally, but I get an attribute error when fastapi-cache tries to initialize ModelField class due to non-existent attributes in the FastAPI compat class when it loads data from cache. Any ideas would be helpful, I'm getting frustrated and will downgrade FastAPI to use Pydantic v1 just for this reason. |
|
@long2ice can we move forward with supporting pedantic > 2 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use fastapi._compat's ModelField if pydantic version is 2, as the ModelField in pydantic v1 is not there in v2 anymore.