Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add longhorn/types #194

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: add longhorn/types #194

merged 2 commits into from
Apr 18, 2024

Conversation

FrankYang0529
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#6744

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@FrankYang0529 FrankYang0529 requested a review from a team as a code owner February 22, 2024 09:36
@FrankYang0529 FrankYang0529 marked this pull request as draft February 22, 2024 09:37
Copy link

mergify bot commented Feb 22, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

innobead
innobead previously approved these changes Apr 10, 2024
Copy link

mergify bot commented Apr 17, 2024

This pull request is now in conflict. Could you fix it @FrankYang0529? 🙏

Signed-off-by: PoAn Yang <poan.yang@suse.com>
Signed-off-by: PoAn Yang <poan.yang@suse.com>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

@FrankYang0529 All are ready?

cc @ChanYiLin

@FrankYang0529
Copy link
Contributor Author

@FrankYang0529 All are ready?

Yes, this PR is ready.

@derekbit derekbit merged commit c6ed5b3 into longhorn:master Apr 18, 2024
6 checks passed
@FrankYang0529 FrankYang0529 deleted the LH-6744 branch April 18, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants