Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support full backup #166

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Mar 19, 2024

ref: longhorn/longhorn#7070

  • Add BackupCount in BackupVolume, so we can calculate the interval to achieve periodically full backup
  • Add NewlyUploadedDataSize and ReUploadedDataSize to each Backup. So user can know the data transfer size for each Backup to trace the cost.
  • Add Parameters to the Backup Config.
    • If the backup has the parameter backup-mode: full, it will pretend there is no last backup, and backup all the blocks of the current volume.

@ChanYiLin ChanYiLin self-assigned this Mar 19, 2024
@ChanYiLin ChanYiLin marked this pull request as draft March 19, 2024 09:34
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 4 times, most recently from ab6fa5e to 33878b2 Compare March 26, 2024 06:23
@ChanYiLin ChanYiLin marked this pull request as ready for review March 26, 2024 06:23
@ChanYiLin ChanYiLin force-pushed the LH7070_support_full_backup branch 6 times, most recently from cefced1 to 0f58353 Compare April 2, 2024 08:17
@ChanYiLin ChanYiLin marked this pull request as draft April 2, 2024 08:28
@ChanYiLin
Copy link
Contributor Author

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.24%. Comparing base (5ec9a30) to head (251a4c2).
Report is 1 commits behind head on master.

Current head 251a4c2 differs from pull request most recent head a14570f

Please upload reports for the commit a14570f to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   18.24%   18.24%           
=======================================
  Files           3        3           
  Lines         433      433           
=======================================
  Hits           79       79           
  Misses        347      347           
  Partials        7        7           
Flag Coverage Δ
unittests 18.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChanYiLin
Copy link
Contributor Author

CI failed, will consult @FrankYang0529

Error response from daemon: {"message":"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version"}
Starting NFS server
Warning: failed to get default registry endpoint from daemon (Error response from daemon: {"message":"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version"}). Using system default: https://index.docker.io/v1/
Error response from daemon: {"message":"client version 1.22 is too old. Minimum supported API version is 1.24, please upgrade your client to a newer version"}

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM.
Only few comments needing to address.

ref: longhorn/longhorn 7070

Signed-off-by: Jack Lin <jack.lin@suse.com>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit e98e31e into longhorn:master Jun 24, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants