fix(azure): close the reader after reading #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantissahz
force-pushed
the
issue8964-close-rc
branch
from
12cc0b7
to
af4371e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #186 +/- ##
=========================================
- Coverage 7.88% 7.87% -0.01%
=========================================
Files 23 23
Lines 2005 2006 +1
=========================================
Hits 158 158
- Misses 1821 1822 +1
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Can you create a bug ticket for the fix? |
mantissahz
force-pushed
the
issue8964-close-rc
branch
from
af4371e
to
38bffea
Compare
Add issue number/link here. Thank you. |
4 tasks
|
Also add ticket number in the commit message |
ref: longhorn/longhorn 9281 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue8964-close-rc
branch
from
38bffea
to
b2687f0
Compare
derekbit
approved these changes
Aug 23, 2024
derekbit
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#9281
What this PR does / why we need it:
Close the reader after reading.
Special notes for your reviewer:
Additional documentation or context