-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support to build in Darwin #71
Conversation
Signed-off-by: Jack Yu <jack.yu@suse.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 79.78% 79.81% +0.02%
==========================================
Files 33 35 +2
Lines 1583 1585 +2
==========================================
+ Hits 1263 1265 +2
Misses 204 204
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Yu-Jack , is this ready? |
@c3y1huang , I'm still checking Codecov code coverage issue. It is supposed to test |
@c3y1huang It's ready. |
Which issue(s) this PR fixes:
longhorn/longhorn#9487
What this PR does / why we need it:
Like longhorn/longhorn#9487 mentioned, it needs to support to build in Darwin.
Special notes for your reviewer:
I've changed syscall to unix in this PR, but I'm not sure what is actually needed in
types/namespace_darwin.go
andns/joiner_darwin.go
. Therefore, I left it as a no-op.Additional documentation or context
None.