Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to build in Darwin #71

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

Yu-Jack
Copy link
Contributor

@Yu-Jack Yu-Jack commented Sep 25, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#9487

What this PR does / why we need it:

Like longhorn/longhorn#9487 mentioned, it needs to support to build in Darwin.

Special notes for your reviewer:

I've changed syscall to unix in this PR, but I'm not sure what is actually needed in types/namespace_darwin.go and ns/joiner_darwin.go. Therefore, I left it as a no-op.

Additional documentation or context

None.

Signed-off-by: Jack Yu <jack.yu@suse.com>
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (797b589) to head (16b0f9d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ns/joiner_linux.go 56.25% 4 Missing and 3 partials ⚠️
sys/sys.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   79.78%   79.81%   +0.02%     
==========================================
  Files          33       35       +2     
  Lines        1583     1585       +2     
==========================================
+ Hits         1263     1265       +2     
  Misses        204      204              
  Partials      116      116              
Flag Coverage Δ
unittests 79.81% <74.19%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c3y1huang
Copy link
Contributor

c3y1huang commented Sep 26, 2024

@Yu-Jack , is this ready?

@Yu-Jack
Copy link
Contributor Author

Yu-Jack commented Sep 26, 2024

@Yu-Jack , is this ready for review?

@c3y1huang , I'm still checking Codecov code coverage issue. It is supposed to test joiner_linux.go. I'll mark it ready after I finish my investigation.

@Yu-Jack Yu-Jack marked this pull request as ready for review September 26, 2024 04:36
@Yu-Jack
Copy link
Contributor Author

Yu-Jack commented Sep 26, 2024

@c3y1huang It's ready. joiner linux.go had been tested actually. I just misunderstood some description ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants