Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use a1.2xlarge machine for arm64 #130

Merged
merged 1 commit into from
Jul 13, 2023
Merged

ci: use a1.2xlarge machine for arm64 #130

merged 1 commit into from
Jul 13, 2023

Conversation

yangchiu
Copy link
Member

ci: use a1.2xlarge machine for arm64

(1) use a1.2xlarge machine for arm64 test to fix test_support_bundle_should_not_timeout failure
(2) add 2 stage upgrade test parameter for v1.5.x and v1.4.x

For longhorn/longhorn-tests#1456

Signed-off-by: Yang Chiu yang.chiu@suse.com

@yangchiu
ci: use a1.2xlarge machine for arm64
81a6870 
(1) use a1.2xlarge machine for arm64 test to fix test_support_bundle_should_not_timeout failure
(2) add 2 stage upgrade test parameter for v1.5.x and v1.4.x

Signed-off-by: Yang Chiu <yang.chiu@suse.com>
@yangchiu yangchiu requested review from innobead, c3y1huang and a team July 13, 2023 04:28
@yangchiu yangchiu self-assigned this Jul 13, 2023
@yangchiu yangchiu mentioned this pull request Jul 13, 2023
Merged
c3y1huang
c3y1huang reviewed Jul 13, 2023
View reviewed changes
Copy link

@c3y1huang c3y1huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for skipping CentOS?

@roger-ryao
Copy link
Contributor

Any reason for skipping CentOS?

Hi @c3y1huang
I believe the reason for skipping CentOS is related to longhorn/website@bcbdec9. This is why CentOS is being skipped.

CC @yangchiu

@c3y1huang
Copy link

c3y1huang commented Jul 13, 2023 •
edited
Loading

Hi @c3y1huang I believe the reason for skipping CentOS is related to longhorn/website@bcbdec9. This is why CentOS is being skipped.

CC @yangchiu

I see, thanks for clarifying.

Since CentOS still exists in the code base and in the pipeline. I think we could still update them to avoid confusion. WDYT @yangchiu @roger-ryao ?

@yangchiu
Copy link
Member Author

Although centos pipeline still exists, there's no way to run it because centos ami images have all been deleted on aws. I think the correct way is to remove centos pipeline from our code base. WDYT @innobead

@khushboo-rancher
Copy link
Contributor

Let's merge this first to let every arm CI run. We can remove the centOs later.

@khushboo-rancher khushboo-rancher merged commit 54ed807 into longhorn:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c3y1huang c3y1huang c3y1huang left review comments

@khushboo-rancher khushboo-rancher khushboo-rancher approved these changes

@innobead innobead Awaiting requested review from innobead

Assignees

@yangchiu yangchiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangchiu @roger-ryao @c3y1huang @khushboo-rancher