Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug the engine might choose a replica with a smaller head size to be the source of truth for auto-salvage (backport #1114) #1118

Merged
merged 2 commits into from
May 31, 2024
Merged

Fix bug the engine might choose a replica with a smaller head size to be the source of truth for auto-salvage (backport #1114) #1118

merged 2 commits into from
May 31, 2024

Commits on May 31, 2024

  1. Fix bug the engine might choose a replica with a smaller head size to be 

    the source of truth for auto-salvage

longhorn-8659

Signed-off-by: Phan Le <phan.le@suse.com>
(cherry picked from commit fd668c9)
    @PhanLe1010 @mergify
    PhanLe1010 authored and mergify[bot] committed May 31, 2024
    Configuration menu
    Copy the full SHA
    fe8ffe5 View commit details
    Browse the repository at this point in the history

  2. Modify the salvageRevisionCounterDisabledReplicas logic 

    The old logic is that:
1. Filter replica candidates to keep only replicas which was modified
   within the last 5 seconds from the last modified replica
2. Then filter to keep only replicas with head size equals to the biggest
   one
3. Then pick a random replica from the set

The new logic:
1. Filter replica candiates to keep only replicas which was modified
   within the last 5 seconds from the last modified replica
2. Then filter to keep only replicas with head size equal to the biggest
   one
3. Then pick the last modified replica from the set

longhorn-8659
longhorn-8563

Signed-off-by: Phan Le <phan.le@suse.com>
(cherry picked from commit 15c1e89)
    @PhanLe1010 @mergify
    PhanLe1010 authored and mergify[bot] committed May 31, 2024
    Configuration menu
    Copy the full SHA
    288bcfe View commit details
    Browse the repository at this point in the history