fix(replica): best-effort to delete old head disk file #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify backport v1.7.x |
✅ Backports have been created
|
derekbit
force-pushed
the
issue-9168
branch
2 times, most recently
from
933a89e
to
302c612
Compare
The deletion of old head disk file is a best-effort task, and the failure should not hinder the following tasks. Longhorn 9168 Signed-off-by: Derek Su <derek.su@suse.com>
innobead
approved these changes
Aug 6, 2024
|
Does this mean there would be chances to have orphaned old head snapshot img? |
Yes, need a manual intervention for the deletion. |
|
@mergify backport v1.6.x |
✅ Backports have been created
|
Backporting to v1.6.x is necessary, because the bug is also in v1.6.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9168
What this PR does / why we need it:
The deletion of old head disk file is a best-effort task, and the failure should not hinder the following tasks.
The regression is caused by the commit.
Special notes for your reviewer:
Additional documentation or context