Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(imports): follow convention in dataconn/client.go #1197

Merged

Conversation

ejweber
Copy link
Collaborator

@ejweber ejweber commented Aug 23, 2024

Which issue(s) this PR fixes:

longhorn/longhorn#8711

What this PR does / why we need it:

Per #1176 (comment), I didn't follow the convention from https://github.com/longhorn/longhorn/wiki/coding-convention#organize-package-imports with a new import.

Longhorn 8711

Signed-off-by: Eric Weber <eric.weber@suse.com>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@derekbit derekbit merged commit 3b01da8 into longhorn:master Aug 23, 2024
11 checks passed
@ejweber
Copy link
Collaborator Author

ejweber commented Aug 26, 2024

@mergify backport v1.7.x

Copy link

mergify bot commented Aug 26, 2024

backport v1.7.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants