Fix high CPU usage of instance-manager pod caused by for loop

Longhorn 8496 Signed-off-by: Derek Su <derek.su@suse.com>
longhorn · May 7, 2024 · 7e13b69 · 7e13b69
1 parent cb2f1f3
commit 7e13b69
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 30 deletions.
diff --git a/pkg/disk/disk.go b/pkg/disk/disk.go
@@ -85,17 +85,10 @@ func NewServer(ctx context.Context, spdkEnabled bool, spdkServiceAddress string)
 }
 
 func (s *Server) startMonitoring() {
-	done := false
 	for {
-		select {
-		case <-s.ctx.Done():
-			logrus.Infof("%s: stopped monitoring replicas due to the context done", types.DiskGrpcService)
-			done = true
-		default:
-		}
-		if done {
-			break
-		}
+		<-s.ctx.Done()
+		logrus.Infof("%s: stopped monitoring due to the context done", types.DiskGrpcService)
+		break
 	}
 }
 

diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go
@@ -83,17 +83,10 @@ func NewServer(ctx context.Context, logsDir, processManagerServiceAddress, spdkS
 }
 
 func (s *Server) startMonitoring() {
-	done := false
 	for {
-		select {
-		case <-s.ctx.Done():
-			logrus.Infof("%s: stopped monitoring replicas due to the context done", types.InstanceGrpcService)
-			done = true
-		default:
-		}
-		if done {
-			break
-		}
+		<-s.ctx.Done()
+		logrus.Infof("%s: stopped monitoring due to the context done", types.InstanceGrpcService)
+		break
 	}
 }
 

diff --git a/pkg/proxy/proxy.go b/pkg/proxy/proxy.go
@@ -79,17 +79,10 @@ func NewProxy(ctx context.Context, logsDir, diskServiceAddress, spdkServiceAddre
 }
 
 func (p *Proxy) startMonitoring() {
-	done := false
 	for {
-		select {
-		case <-p.ctx.Done():
-			logrus.Infof("%s: stopped monitoring replicas due to the context done", types.ProxyGRPCService)
-			done = true
-		default:
-		}
-		if done {
-			break
-		}
+		<-p.ctx.Done()
+		logrus.Infof("%s: stopped monitoring due to the context done", types.ProxyGRPCService)
+		break
 	}
 }