nit(refactor): remove the unnecessary for loop

longhorn-9438 Signed-off-by: Phan Le <phan.le@suse.com>
longhorn · Sep 12, 2024 · bce3e41 · bce3e41
1 parent eea871e
commit bce3e41
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 15 deletions.
diff --git a/pkg/disk/disk.go b/pkg/disk/disk.go
@@ -85,11 +85,8 @@ func NewServer(ctx context.Context, spdkEnabled bool, spdkServiceAddress string)
 }
 
 func (s *Server) startMonitoring() {
-	for {
-		<-s.ctx.Done()
-		logrus.Infof("%s: stopped monitoring due to the context done", types.DiskGrpcService)
-		break
-	}
+	<-s.ctx.Done()
+	logrus.Infof("%s: stopped monitoring due to the context done", types.DiskGrpcService)
 }
 
 func (s *Server) VersionGet(ctx context.Context, req *emptypb.Empty) (*rpc.DiskVersionResponse, error) {

diff --git a/pkg/instance/instance.go b/pkg/instance/instance.go
@@ -87,11 +87,8 @@ func NewServer(ctx context.Context, logsDir, processManagerServiceAddress, spdkS
 }
 
 func (s *Server) startMonitoring() {
-	for {
-		<-s.ctx.Done()
-		logrus.Infof("%s: stopped monitoring due to the context done", types.InstanceGrpcService)
-		break
-	}
+	<-s.ctx.Done()
+	logrus.Infof("%s: stopped monitoring due to the context done", types.InstanceGrpcService)
 }
 
 func (s *Server) VersionGet(ctx context.Context, req *emptypb.Empty) (*rpc.VersionResponse, error) {

diff --git a/pkg/proxy/proxy.go b/pkg/proxy/proxy.go
@@ -78,11 +78,8 @@ func NewProxy(ctx context.Context, logsDir, diskServiceAddress, spdkServiceAddre
 }
 
 func (p *Proxy) startMonitoring() {
-	for {
-		<-p.ctx.Done()
-		logrus.Infof("%s: stopped monitoring due to the context done", types.ProxyGRPCService)
-		break
-	}
+	<-p.ctx.Done()
+	logrus.Infof("%s: stopped monitoring due to the context done", types.ProxyGRPCService)
 }
 
 func (p *Proxy) ServerVersionGet(ctx context.Context, req *rpc.ProxyEngineRequest) (resp *rpc.EngineVersionProxyResponse, err error) {