Skip to content

Commit

Permalink
nit(refactor): remove the unnecessary for loop
Browse files Browse the repository at this point in the history
longhorn-9438

Signed-off-by: Phan Le <phan.le@suse.com>
(cherry picked from commit 00a5464)

# Conflicts:
#	pkg/disk/disk.go
#	pkg/instance/instance.go
#	pkg/proxy/proxy.go
  • Loading branch information
PhanLe1010 authored and mergify[bot] committed Sep 13, 2024
1 parent a6dddfa commit c48f596
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/disk/disk.go
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ func NewServer(ctx context.Context, spdkEnabled bool, spdkServiceAddress string)

func (s *Server) startMonitoring() {
<-s.ctx.Done()
<<<<<<< HEAD
logrus.Infof("%s: stopped monitoring replicas due to the context done", types.DiskGrpcService)
=======
logrus.Infof("%s: stopped monitoring due to the context done", types.DiskGrpcService)
>>>>>>> 00a5464f (nit(refactor): remove the unnecessary for loop)
}

func (s *Server) VersionGet(ctx context.Context, req *emptypb.Empty) (*rpc.DiskVersionResponse, error) {
Expand Down
4 changes: 4 additions & 0 deletions pkg/instance/instance.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ func NewServer(ctx context.Context, logsDir, processManagerServiceAddress, spdkS

func (s *Server) startMonitoring() {
<-s.ctx.Done()
<<<<<<< HEAD
logrus.Infof("%s: stopped monitoring replicas due to the context done", types.InstanceGrpcService)
=======
logrus.Infof("%s: stopped monitoring due to the context done", types.InstanceGrpcService)
>>>>>>> 00a5464f (nit(refactor): remove the unnecessary for loop)
}

func (s *Server) VersionGet(ctx context.Context, req *emptypb.Empty) (*rpc.VersionResponse, error) {
Expand Down
4 changes: 4 additions & 0 deletions pkg/proxy/proxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,11 @@ func NewProxy(ctx context.Context, logsDir, diskServiceAddress, spdkServiceAddre

func (p *Proxy) startMonitoring() {
<-p.ctx.Done()
<<<<<<< HEAD
logrus.Infof("%s: stopped monitoring replicas due to the context done", types.ProxyGRPCService)
=======
logrus.Infof("%s: stopped monitoring due to the context done", types.ProxyGRPCService)
>>>>>>> 00a5464f (nit(refactor): remove the unnecessary for loop)
}

func (p *Proxy) ServerVersionGet(ctx context.Context, req *rpc.ProxyEngineRequest) (resp *rpc.EngineVersionProxyResponse, err error) {
Expand Down

0 comments on commit c48f596

Please sign in to comment.