-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(utils): move is mount read only function to common lib #418
refactor(utils): move is mount read only function to common lib #418
Conversation
7a4a8e5
to
2315297
Compare
2315297
to
71faa72
Compare
it seems we should wait until longhorn/longhorn#7578 finished
cc @derekbit |
cc @DamiaSan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Resolve the feedback, then we can merge this PR.
71faa72
to
b05bde6
Compare
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
b05bde6
to
768a5d8
Compare
ref: longhorn/longhorn 7394 Signed-off-by: Jack Lin <jack.lin@suse.com>
768a5d8
to
072ebf8
Compare
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
ref: longhorn/longhorn#7394
Add mount related util function: IsMountPointReadOnly
This is used in share-manager and instance-manager to detect if the mount point becomes readonly.
Note:
So when updating the version, we also need to fix some code to meet the changes in go-common-libs
e.g.
go-spdk-helper
is also needed to updatelonghorn-spdk-engine
is also needed to updatecc @derekbit