Allow retrying killing a process when it get stucks in stopping state #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Longhorn 8091 Signed-off-by: Shuo Wu <shuo.wu@suse.com>
ejweber
reviewed
Mar 26, 2024
Longhorn 8091 Signed-off-by: Shuo Wu <shuo.wu@suse.com>
derekbit
reviewed
Mar 27, 2024
| needStop = true | ||
| } | ||
| // Retry the deletion if the process is not stopped in 30 seconds |
There was a problem hiding this comment.
60 seconds?
WaitInterval is 100ms and WaitCount is 600.
There was a problem hiding this comment.
Yeah. I forgot to update this comment. Will do it with a new PR
innobead
approved these changes
Mar 27, 2024
|
@mergify backport v1.6.x 1.5.x |
❌ No backport have been created
GitHub error: |
|
cc @longhorn/qa need to ensure replica related e2e test cases succeed as usual. |
|
@mergify backport v1.5.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8091
What this PR does / why we need it:
We don't know how to reproduce this issue. But this PR allows retrying the process kill after a timeout anyway
Special notes for your reviewer:
Additional documentation or context