Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit(refactor): remove the unnecessary for loop #665

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

PhanLe1010
Copy link
Contributor

@PhanLe1010 PhanLe1010 commented Sep 12, 2024

longhorn/longhorn#9438

Fixing a nit. We don't need the for loop

longhorn-9438

Signed-off-by: Phan Le <phan.le@suse.com>
@PhanLe1010 PhanLe1010 requested a review from a team September 12, 2024 23:22
@PhanLe1010
Copy link
Contributor Author

@mergify backport 1.7.x

Copy link

mergify bot commented Sep 12, 2024

backport 1.7.x

❌ No backport have been created

  • Backport to branch 1.7.x failed

GitHub error: Branch not found

@longhorn longhorn deleted a comment from mergify bot Sep 12, 2024
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit
Copy link
Member

We can more categories such as nit and vendor in the Conventional Commits rules.

@derekbit derekbit merged commit 00a5464 into longhorn:master Sep 13, 2024
10 of 12 checks passed
@derekbit
Copy link
Member

@mergify backport v1.7.x v1.6.x

Copy link

mergify bot commented Sep 13, 2024

backport 1.7.x 1.6.x

❌ No backport have been created

  • Backport to branch 1.7.x failed

GitHub error: Branch not found

  • Backport to branch 1.6.x failed

GitHub error: Branch not found

Copy link

mergify bot commented Sep 13, 2024

backport v1.7.x v1.6.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants