fix: remove the logic that sets datalocality to disable when v2 volum…

…e is created Signed-off-by: jinhong.kim0 <jinhong.kim0@navercorp.com>
longhorn · Sep 23, 2024 · 2edf8ec · 2edf8ec
1 parent 3c3e123
commit 2edf8ec
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/webhook/resources/volume/mutator.go b/webhook/resources/volume/mutator.go
@@ -196,9 +196,6 @@ func (v *volumeMutator) Create(request *admission.Request, newObj runtime.Object
 
 	// TODO: Remove the mutations below after they are implemented for SPDK volumes
 	if types.IsDataEngineV2(volume.Spec.DataEngine) {
-		if volume.Spec.DataLocality != longhorn.DataLocalityDisabled {
-			patchOps = append(patchOps, fmt.Sprintf(`{"op": "replace", "path": "/spec/dataLocality", "value": "%s"}`, longhorn.DataLocalityDisabled))
-		}
 		if volume.Spec.SnapshotDataIntegrity != longhorn.SnapshotDataIntegrityDisabled {
 			patchOps = append(patchOps, fmt.Sprintf(`{"op": "replace", "path": "/spec/snapshotDataIntegrity", "value": "%s"}`, longhorn.SnapshotDataIntegrityDisabled))
 		}

diff --git a/webhook/resources/volume/validator.go b/webhook/resources/volume/validator.go
@@ -266,12 +266,6 @@ func (v *volumeValidator) Update(request *admission.Request, oldObj runtime.Obje
 			return werror.NewInvalidError(err.Error(), "")
 		}
 
-		if oldVolume.Spec.DataLocality != newVolume.Spec.DataLocality {
-			err := fmt.Errorf("changing data locality for volume %v is not supported for data engine %v",
-				newVolume.Name, newVolume.Spec.DataEngine)
-			return werror.NewInvalidError(err.Error(), "")
-		}
-
 		if oldVolume.Spec.SnapshotDataIntegrity != newVolume.Spec.SnapshotDataIntegrity {
 			err := fmt.Errorf("changing snapshot data integrity for volume %v is not supported for data engine %v",
 				newVolume.Name, newVolume.Spec.DataEngine)