fix(recurringjob): keep snapshots for the backup #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
c4ea633
to
8d3fec8
Compare
shuo-wu
previously approved these changes
Jun 30, 2023
|
@mergify backport v1.5.x |
✅ Backports have been created
|
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
babace2
to
5039b39
Compare
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
fa84d4c
to
c80ff96
Compare
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
d036d62
to
a471f6c
Compare
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
5f1d613
to
89871f0
Compare
c3y1huang
reviewed
Oct 24, 2023
mantissahz
force-pushed
the
issue2997
branch
2 times, most recently
from
92d2891
to
9dfd109
Compare
c3y1huang
approved these changes
Oct 25, 2023
Add a new global setting that allows users to keep the retain number of snapshots when the recurring job does a backup. Ref: 2997 Signed-off-by: James Lu <james.lu@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new global setting that allows users to keep the retain number of snapshots when the recurring job does a backup.
Ref: longhorn/longhorn#2997