Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(setting): add tolerate node disk empty selector volume setting #2078

Merged
merged 2 commits into from
Aug 8, 2023
Merged

feat(setting): add tolerate node disk empty selector volume setting #2078

merged 2 commits into from
Aug 8, 2023

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin requested a review from a team as a code owner July 13, 2023 05:08
@ChanYiLin ChanYiLin marked this pull request as draft July 13, 2023 05:14
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch from 6b26604 to 766c48d Compare July 13, 2023 05:21
@ChanYiLin ChanYiLin marked this pull request as ready for review July 13, 2023 05:32
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch from 766c48d to 6c55528 Compare July 13, 2023 05:37
@ChanYiLin ChanYiLin mentioned this pull request Jul 13, 2023
Closed
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch from 6c55528 to 7a850fb Compare July 13, 2023 05:48
shuo-wu
shuo-wu previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM

types/types.go Outdated Show resolved Hide resolved
types/setting.go Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch from 7a850fb to e413988 Compare July 17, 2023 06:43
innobead
innobead requested changes Jul 27, 2023
View reviewed changes
types/setting.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
controller/volume_controller.go Outdated Show resolved Hide resolved
scheduler/replica_scheduler.go Outdated Show resolved Hide resolved
scheduler/replica_scheduler.go Outdated Show resolved Hide resolved
scheduler/replica_scheduler.go Outdated Show resolved Hide resolved
scheduler/replica_scheduler.go Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch 2 times, most recently from eb32607 to ea666e5 Compare August 1, 2023 04:29
@ChanYiLin ChanYiLin requested a review from innobead August 2, 2023 01:46
innobead
innobead requested changes Aug 8, 2023
View reviewed changes
scheduler/replica_scheduler.go Outdated Show resolved Hide resolved
@innobead
Copy link
Member

innobead commented Aug 8, 2023

@ChanYiLin Also, the chart manifests need to update.

@ChanYiLin
feat(setting): add tolerate node disk empty selector volume setting
a90917c 
ref: longhorn/longhorn 4826

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin ChanYiLin force-pushed the LH4826_add_setting_tolerate_empty_tag_replica branch from d3ffcf8 to a90917c Compare August 8, 2023 08:35
@innobead innobead enabled auto-merge (rebase) August 8, 2023 08:38
@innobead innobead disabled auto-merge August 8, 2023 08:45
@innobead innobead merged commit 840dbf1 into longhorn:master Aug 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

@shuo-wu shuo-wu shuo-wu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanYiLin @innobead @shuo-wu