-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replicaName argument to ReplicaRebuildVerify #2108
Add replicaName argument to ReplicaRebuildVerify #2108
Conversation
71310d4
to
3f781c3
Compare
Longhorn 6522 Signed-off-by: Eric Weber <eric.weber@suse.com>
3f781c3
to
bb7dc3e
Compare
Tested on my own cluster since I haven't been able to figure out how to pass a 9/10 tests passed on the first run. I tried the last one again and it passed on a second run. Not sure if that one is prone to flaking? But the logs did not indicate anything like the issue this PR is fixing.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
longhorn/longhorn#6522
I added the replicaName argument to instance-manager's ReplicaRebuildVerify client method (and the associated gRPC request) as a part of longhorn/longhorn#5845, but I did not create a way for longhorn-manager to provide it. This PR fixes the issue and allows the tests mentioned in longhorn/longhorn#6522 to pass.