feat(backup): multiple backup stores support #2182
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is now in conflicts. Could you fix it @mantissahz? 🙏 |
|
This pull request is now in conflicts. Could you fix it @mantissahz? 🙏 |
mantissahz
force-pushed
the
issue5411
branch
3 times, most recently
from
a782b93
to
142535f
Compare
|
Is this ready for review? |
@innobead Yes, but LEP longhorn/longhorn#6630 is still in review. |
mantissahz
force-pushed
the
issue5411
branch
3 times, most recently
from
c1e1178
to
4cdb679
Compare
james-munson
reviewed
Dec 4, 2023
james-munson
reviewed
Dec 8, 2023
james-munson
reviewed
Dec 8, 2023
james-munson
requested changes
Dec 8, 2023
mantissahz
force-pushed
the
issue5411
branch
from
4e67c1e
to
fe4d30c
Compare
ChanYiLin
requested changes
Dec 12, 2023
Introduce a new filed `BackupTargetName` in `Volume.Spec` to point out where the volume will be backed up to. ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
List backup volume CRs using a backup target name. List backup volume CRs using a volume name. Get a backup volume using a backup target name and a volume name. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue5411
branch
from
89cf826
to
29b1cbf
Compare
Add the backup target mutator and add the finalizer into the backupTarget CR when mutating. ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add the volume mutation and validation to handle the field `Spec.BackupTargetName`. Add a new label "backup-target". Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add fields `Spec.BackingImage` and `Spec.BackupTargetName` in the BackupBackingImage CRD Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
1. Add the deleting function. 2. Modify the synchronizing backup volumes and backup backing images from a backup target methods. 3. `sets.String` is deprecated and use generic `Set` instead Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Move backupTimer from setting controller to backup target controller Move AWS IAM Role Annotation logic to datastore/kubernetes.go Ref: 5411, 6947 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Remove adding `backup-target` back when node is updated. Remove backup targets when uninstalling. ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Introduce a new filed `BackupTargetName` in `Volume.Spec` to point out where the volume will be backed up to. ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Modify backup volume controller to support multiple backup stores support. Synchronize and handle the backup volumes information from different backup targets with the same backup volume name or not. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Modify backup controller to support multiple backup stores support. Synchronize and handle the backup information from different backup targets with the same backup volume name or not. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue5411
branch
2 times, most recently
from
3aa2730
to
50c6d74
Compare
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
add the method to get the correct BackupVolume with the volume name and backup target name for the recurring job and related data strucurtes of APIs. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add more parameters in creating BackupVolume for testing volume_controller.go Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Add more parameters in creating BackupVolume for testing volume_controller.go Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Upgrade CRs for Volume, BackupVolume, Backup, BackupBackingImage, and BackingImageDataSource. Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
Ref: 5411 Signed-off-by: James Lu <james.lu@suse.com>
mantissahz
force-pushed
the
issue5411
branch
from
50c6d74
to
442d9f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple backup stores to create, delete and update them.
Remove the
defaultbackup target instead usingDefaultflag inBackupTargetCR spec.Adding a flag
ReadOnlyinBackupTargetCR spec prevent backups from being created and storing on this remote backup target.And provide HTTP endpoints to create, delete, update and list secrets.
Ref: longhorn/longhorn#5411