fix(setting): check both setting and definition default for possible … #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuo-wu
reviewed
Feb 9, 2024
james-munson
force-pushed
the
7755-setting-definition-default
branch
from
aece765
to
66f515e
Compare
james-munson
force-pushed
the
7755-setting-definition-default
branch
from
66f515e
to
8fd1c05
Compare
|
Rebased and re-pushed. |
james-munson
force-pushed
the
7755-setting-definition-default
branch
from
8fd1c05
to
5b350e9
Compare
|
Rebased and re-pushed. What is holding up this PR? |
james-munson
force-pushed
the
7755-setting-definition-default
branch
from
5b350e9
to
c56bc11
Compare
james-munson
force-pushed
the
7755-setting-definition-default
branch
2 times, most recently
from
1a73a40
to
bd0c0c5
Compare
shuo-wu
approved these changes
Mar 8, 2024
…change. Signed-off-by: James Munson <james.munson@suse.com>
shuo-wu
force-pushed
the
7755-setting-definition-default
branch
from
bd0c0c5
to
32bbec0
Compare
|
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
This was referenced Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…change.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7755
What this PR does / why we need it:
When checking a potential configmap change for default settings, check not only the current setting value but also the setting definition default value to decide whether there is a change to apply.
Special notes for your reviewer:
Additional documentation or context