-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(system-backup): support backup backing image #2710
feat(system-backup): support backup backing image #2710
Conversation
aed6527
to
42619ff
Compare
Manual Test
|
Could you also help to update the LEP? |
Can this be automated? |
Hi @c3y1huang |
Hi @c3y1huang |
Hi @c3y1huang |
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
1 similar comment
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
42619ff
to
746b733
Compare
Fixed. |
746b733
to
c6965b1
Compare
b5add36
to
ce7c71b
Compare
ref: longhorn/longhorn 5085 Signed-off-by: Jack Lin <jack.lin@suse.com>
ce7c71b
to
c253ee2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mergify backport v1.6.x |
✅ Backports have been created
|
ref: longhorn/longhorn#5085
After backing up Volumes
: Because now we already backup BackingImage when backing up Volumes, In this stage, we only backup those BackingImages not being used.Before restoring Volumes
: Because Volume with BackingImage creation will fail if there is no BackingImage in the clusterlast-skipped-system-restored
andlast-skipped-system-restored-at
restore
type BackingImageChecksum: restore.Status.Checksum,
to verify the BackingImage (checksum from the yaml system-backup stored)last-system-restored
andlast-system-restored-at