feat(rwx): share manager locality #2716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
changed the title
storageClass.Parameters["shareManagerNodeSelector"]storageClass.Parameters["shareManagerNodeSelector"]
derekbit
changed the title
storageClass.Parameters["shareManagerNodeSelector"]
shuo-wu
reviewed
Apr 3, 2024
james-munson
reviewed
Apr 3, 2024
…ss.Parameters["shareManagerNodeSelector"] The commit introduces an enhancement for specifying the locality of a Read-Write-Many (RWX) volume and its associated Share Manager Pod within the Longhorn storage system. Previously, an RWX volume and its Share Manager Pod were created randomly on any node within the Longhorn cluster, without the ability for users to specify a preferred locality. Longhorn 7872 Signed-off-by: Derek Su <derek.su@suse.com>
In the Longhorn storage system, a share manager pod of a rwx volume is created on a random node. The purpose of this update is to enhance the locality of an RWX volume and its share manager pod. It accomplishes this by converting the storageClass.allowedTopologies setting into an affinity configuration for the share manager pod. As a result, both the pod and the RWX volume respect this affinity, ensuring their allocation to an optimal node. Longhorn 7872 Signed-off-by: Derek Su <derek.su@suse.com>
…ss.Parameters["shareManagerTolerations"] Share manager pod respects the newly introduced storageClass.Parameters["shareManagerTolerations"]. The tolerations are merged with the global setting taint-toleration and are applied to share manager pod. Longhron 7872 Signed-off-by: Derek Su <derek.su@suse.com>
|
cc @shuo-wu @PhanLe1010 @james-munson @innobead for review and approval. Thank you. |
james-munson
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#7872
What this PR does / why we need it:
storageClass.Parameters["shareManagerNodeSelector"]storageClass.allowedTopologieswhich are internally converted to the affinity of a share manager podstorageClass.Parameters["shareManagerTolerations"]Special notes for your reviewer:
Additional documentation or context