Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backingimage): backingimage ha eviction enhancement #2742

Merged
merged 3 commits into from
Jul 2, 2024
Merged

feat(backingimage): backingimage ha eviction enhancement #2742

merged 3 commits into from
Jul 2, 2024

Conversation

ChanYiLin
Copy link
Contributor

@ChanYiLin ChanYiLin commented Apr 25, 2024 •
edited
Loading

ref: longhorn/longhorn#2856

  1. Add minNumberOfCopies
  2. Add nodeSelector, diskSelector
  3. Change the Spec.Disks to Spec.DiskFileSpecMap and Add evictionRequested
  4. Periodically replenish the copies if the number of healthy copies less than the minNumberOfCopies or eviction situation
    • replenishBackingImageCopies()
      • if nonFailedCopies >= MinNumberOfCopies, we check if we need to replenish one copy for eviction
        • replenish one if NonEvictingCount < MinNumberOfCopies
      • if nonFailedCopies < MinNumberOfCopies
        • replenish one copy to meet the MinNumberOfCopies requirement.
  5. Periodically delete evicted copies
    • cleanupEvictionRequestedBackingImageCopies()
      • If there is no non evicted healthy copy, don't delete the copy.
      • Otherwise, delete the evicted copy.
  6. Add concurrent-backing-image-replenish-per-node-limit to limit the number of BackingImage being synced on the same node at the same time
    • if the number = 0, longhorn won't replenish the BackingImage to new node/disk
  7. Adjust replica scheduler, replica won't be scheduled to the node where BackingImage can not be stored.

@ChanYiLin ChanYiLin self-assigned this Apr 25, 2024
@mergify Mergify
Copy link

mergify bot commented Apr 25, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 3 times, most recently from f6f2738 to cb486bd Compare April 26, 2024 07:21
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 2 times, most recently from 93b1320 to d1e592d Compare April 26, 2024 09:27
@ChanYiLin
Copy link
Contributor Author

ChanYiLin commented Apr 26, 2024 •
edited
Loading

Hi @shuo-wu
I don't know the context why we always keep the first prepared file when cleanup backing image file on the disk in node controller here
I think maybe there is a case when a user tries to evict the file on that node.
Besides, the first prepared file has nothing special
If all the files are failed, we still cleanup the bids.Spec.NodeID and bids.Spec.DiskUUID to restart the prepare process.

So I changed the logic to

  • only starts to cleanup backing image file on the disk when the file is transferred
  • it is okay to clean up the file on the first prepared file

WDYT?
Thansk

@ChanYiLin ChanYiLin marked this pull request as ready for review April 26, 2024 09:33
@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 2 times, most recently from a598b5f to 260a658 Compare April 26, 2024 15:46
@mergify Mergify
Copy link

mergify bot commented Apr 27, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 5 times, most recently from d17ffbf to b10b965 Compare April 29, 2024 09:55
@ChanYiLin ChanYiLin mentioned this pull request Apr 30, 2024
Merged
@ChanYiLin
Copy link
Contributor Author

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

fixed.

@ChanYiLin ChanYiLin mentioned this pull request May 2, 2024
Closed
@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 3 times, most recently from 5bcae3b to 72fc205 Compare May 2, 2024 07:52
@mergify Mergify
Copy link

mergify bot commented May 2, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 2 times, most recently from 2226465 to 5d5160f Compare May 23, 2024 07:06
@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 2 times, most recently from 5eed3ff to b108be3 Compare June 7, 2024 04:41
@ChanYiLin
Copy link
Contributor Author

E2E Test PASSED

https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7009/

@ChanYiLin ChanYiLin requested a review from shuo-wu June 11, 2024 09:41
shuo-wu
shuo-wu reviewed Jun 12, 2024
View reviewed changes
controller/backing_image_controller.go Outdated Show resolved Hide resolved
controller/backing_image_manager_controller.go Outdated Show resolved Hide resolved
controller/backing_image_controller.go Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 5 times, most recently from ede6a74 to 8973d98 Compare June 19, 2024 04:36
@ChanYiLin ChanYiLin requested a review from shuo-wu June 19, 2024 04:44
@mergify Mergify
Copy link

mergify bot commented Jul 1, 2024

This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏

derekbit
derekbit reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue reviewing the controllers and scheduler tomorrow morning.

k8s/pkg/apis/longhorn/v1beta2/backingimage.go Show resolved Hide resolved
types/setting.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
types/types.go Outdated Show resolved Hide resolved
webhook/resources/backingimage/mutator.go Outdated Show resolved Hide resolved
webhook/resources/backingimage/mutator.go Outdated Show resolved Hide resolved
webhook/resources/backingimage/mutator.go Outdated Show resolved Hide resolved
webhook/resources/backingimage/mutator.go Outdated Show resolved Hide resolved
shuo-wu
shuo-wu reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@shuo-wu shuo-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM except for the some comments from Derek

controller/backing_image_controller.go Show resolved Hide resolved
derekbit
derekbit reviewed Jul 2, 2024
View reviewed changes
controller/node_controller.go Show resolved Hide resolved
controller/node_controller.go Show resolved Hide resolved
datastore/longhorn.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/node_controller.go Outdated Show resolved Hide resolved
controller/replica_controller.go Outdated Show resolved Hide resolved
controller/backing_image_manager_controller.go Outdated Show resolved Hide resolved
controller/backing_image_manager_controller.go Show resolved Hide resolved
controller/backing_image_manager_controller.go Outdated Show resolved Hide resolved
controller/backing_image_manager_controller.go Outdated Show resolved Hide resolved
@ChanYiLin ChanYiLin force-pushed the LH2856_BackingImage_HA branch 2 times, most recently from b7ae78e to 5a8e760 Compare July 2, 2024 07:12
@ChanYiLin @derekbit
feat(backingimage): backingimage ha eviction enhancement
4764bdf 
ref: longhorn/longhorn 2856

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin @derekbit
feat(backingimage): add new diskFileSpecMap to backingimage
c26c3c5 
ref: longhorn/longhorn 2856

Signed-off-by: Jack Lin <jack.lin@suse.com>
@ChanYiLin @derekbit
fix(BackingImage): use Spec.DiskFileSpecMap as useddisks when getting…
2740909 
… ready node and disk for BackingImage

ref: longhorn/longhorn 2856

Signed-off-by: Jack Lin <jack.lin@suse.com>
derekbit
derekbit approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit a13e767 into longhorn:master Jul 2, 2024
7 checks passed
This was referenced Jul 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbit derekbit derekbit approved these changes

@innobead innobead Awaiting requested review from innobead

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

Assignees

@ChanYiLin ChanYiLin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChanYiLin @derekbit @shuo-wu