Add replace directive clarifying comment #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
This pull request is now in conflict. Could you fix it @ejweber? 🙏 |
Longhorn 8481 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
8481-clarify-replace
branch
from
7c4d94f
to
7b956a1
Compare
innobead
approved these changes
May 2, 2024
|
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
This was referenced May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8481
Additional documentation or context
I will wait on #2592 to transition this to ready for review, since it might make merging that one more difficult (and that one will likely make this one unmergeable without modification).