Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(support-bundle): add support-bundle-node-collection-timeout setting #2825

Conversation

c3y1huang
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8623

What this PR does / why we need it:

Propose adding a setting that allows users to configure the node bundle collection timeout during support bundle generation.

Special notes for your reviewer:

None

Additional documentation or context

rancher/support-bundle-kit#109

@c3y1huang c3y1huang self-assigned this May 28, 2024
@c3y1huang c3y1huang force-pushed the feat-support-bundle-node-bundle-collection-timeout branch 3 times, most recently from 206e02a to 7ab5863 Compare May 28, 2024 03:49
@c3y1huang c3y1huang requested a review from a team May 28, 2024 03:52
@c3y1huang c3y1huang marked this pull request as ready for review May 28, 2024 03:52
@c3y1huang
Copy link
Contributor Author

cc @Yu-Jack

types/setting.go Outdated Show resolved Hide resolved
@c3y1huang c3y1huang requested review from innobead and a team May 28, 2024 04:58
longhorn/longhorn-8623

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-8623

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
@c3y1huang c3y1huang force-pushed the feat-support-bundle-node-bundle-collection-timeout branch from 32f95d4 to 826fd2a Compare May 28, 2024 07:44
@innobead
Copy link
Member

Please pay attention to users feedback in the future, so we can continue improving UX.

@innobead innobead merged commit 05ee2b1 into longhorn:master May 28, 2024
5 checks passed
@c3y1huang c3y1huang deleted the feat-support-bundle-node-bundle-collection-timeout branch May 28, 2024 07:59
@c3y1huang
Copy link
Contributor Author

@mergify backport v1.6.x v1.5.x

Copy link

mergify bot commented May 28, 2024

backport v1.6.x v1.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants