-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(support-bundle): add support-bundle-node-collection-timeout setting #2825
Merged
innobead
merged 2 commits into
longhorn:master
from
c3y1huang:feat-support-bundle-node-bundle-collection-timeout
May 28, 2024
Merged
feat(support-bundle): add support-bundle-node-collection-timeout setting #2825
innobead
merged 2 commits into
longhorn:master
from
c3y1huang:feat-support-bundle-node-bundle-collection-timeout
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3y1huang
force-pushed
the
feat-support-bundle-node-bundle-collection-timeout
branch
3 times, most recently
from
May 28, 2024 03:49
206e02a
to
7ab5863
Compare
cc @Yu-Jack |
innobead
reviewed
May 28, 2024
longhorn/longhorn-8623 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-8623 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
feat-support-bundle-node-bundle-collection-timeout
branch
from
May 28, 2024 07:44
32f95d4
to
826fd2a
Compare
innobead
approved these changes
May 28, 2024
Please pay attention to users feedback in the future, so we can continue improving UX. |
@mergify backport v1.6.x v1.5.x |
✅ Backports have been created
|
This was referenced May 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#8623
What this PR does / why we need it:
Propose adding a setting that allows users to configure the node bundle collection timeout during support bundle generation.
Special notes for your reviewer:
None
Additional documentation or context
rancher/support-bundle-kit#109