Improve interaction between volume attachment controller and migrations #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejweber
force-pushed
the
3401-cancel-migration-node-down-agreed-idea
branch
from
4fa50e7
to
fff650e
Compare
ejweber
changed the title
ejweber
force-pushed
the
3401-cancel-migration-node-down-agreed-idea
branch
6 times, most recently
from
4cb0462
to
f267d5b
Compare
|
The behaviors in this PR now match the test cases from longhorn/longhorn-tests#1948. It is ready for review. |
ejweber
force-pushed
the
3401-cancel-migration-node-down-agreed-idea
branch
from
80c4f7f
to
ffe4a02
Compare
|
I will review this |
ejweber
force-pushed
the
3401-cancel-migration-node-down-agreed-idea
branch
from
ffe4a02
to
e570152
Compare
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3041 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
…node Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
Longhorn 3401 Signed-off-by: Eric Weber <eric.weber@suse.com>
ejweber
force-pushed
the
3401-cancel-migration-node-down-agreed-idea
branch
from
e570152
to
b5e93c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8735
What this PR does / why we need it:
See context at longhorn/longhorn#8735 (comment) and implementation plan at longhorn/longhorn#8735 (comment).
This is a draft for now as I work on testing it in all situations.