Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not change the revisionCounterDisabled as it is an immutable field after creation (backport #3085) #3093

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 24, 2024

Which issue(s) this PR fixes:

Issue # longhorn/longhorn#9279

What this PR does / why we need it:

Refer to longhorn/longhorn#9279 (comment)


This is an automatic backport of pull request #3085 done by [Mergify](https://mergify.com).

It is an immutable field after creation

longhorn-9279

Signed-off-by: Phan Le <phan.le@suse.com>
(cherry picked from commit 01e7627)
@mergify mergify bot requested a review from a team as a code owner August 24, 2024 05:33
@mergify mergify bot added the conflicts label Aug 24, 2024
Copy link
Author

mergify bot commented Aug 24, 2024

Cherry-pick of 2328a53 has failed:

On branch mergify/bp/v1.6.x/pr-3085
Your branch is ahead of 'origin/v1.6.x' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 2328a530.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   webhook/resources/volume/mutator.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@derekbit
Copy link
Member

cc @PhanLe1010

It is an immutable field after creation

longhorn-927

Signed-off-by: Phan Le <phan.le@suse.com>
(cherry picked from commit 2328a53)
@PhanLe1010 PhanLe1010 merged commit f2733a6 into v1.6.x Aug 26, 2024
6 checks passed
@PhanLe1010 PhanLe1010 deleted the mergify/bp/v1.6.x/pr-3085 branch August 26, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants