feat: add real size to backing image #3104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanYiLin
force-pushed
the
LH8757_record_backing_image_real_size
branch
2 times, most recently
from
d282af0
to
c22ca97
Compare
|
This pull request is now in conflict. Could you fix it @ChanYiLin? 🙏 |
PendingWait for
|
ChanYiLin
force-pushed
the
LH8757_record_backing_image_real_size
branch
3 times, most recently
from
1a5db6c
to
a82928a
Compare
ChanYiLin
force-pushed
the
LH8757_record_backing_image_real_size
branch
3 times, most recently
from
9c0468a
to
6a00d8f
Compare
derekbit
reviewed
Sep 25, 2024
| if info.RealSize > 0 { | ||
| if bi.Status.RealSize == 0 { | ||
| bi.Status.RealSize = info.RealSize | ||
| bic.eventRecorder.Eventf(bi, corev1.EventTypeNormal, constant.EventReasonUpdate, "Set realSize to %v", bi.Status.RealSize) |
There was a problem hiding this comment.
I am fine with this update. Backing image actual/real size update should be an one-time update.
shuo-wu
approved these changes
Sep 25, 2024
| if info.RealSize > 0 { | ||
| if bi.Status.RealSize == 0 { | ||
| bi.Status.RealSize = info.RealSize | ||
| bic.eventRecorder.Eventf(bi, corev1.EventTypeNormal, constant.EventReasonUpdate, "Set realSize to %v", bi.Status.RealSize) |
There was a problem hiding this comment.
I am fine with this update. Backing image actual/real size update should be an one-time update.
| if bi.Status.DiskFileStatusMap[bim.Spec.DiskUUID].State != longhorn.BackingImageStateFailed { | ||
| msg := fmt.Sprintf("found mismatching realSize %v reported by backing image manager %v in disk %v, the realSoze recorded in status is %v", | ||
| info.RealSize, bim.Name, bim.Spec.DiskUUID, bi.Status.RealSize) | ||
| log.Error(msg) |
There was a problem hiding this comment.
NIT: Use bic.eventRecorder
derekbit
reviewed
Sep 27, 2024
| } | ||
| if bi.Status.RealSize != info.RealSize { | ||
| if bi.Status.DiskFileStatusMap[bim.Spec.DiskUUID].State != longhorn.BackingImageStateFailed { | ||
| msg := fmt.Sprintf("found mismatching realSize %v reported by backing image manager %v in disk %v, the realSoze recorded in status is %v", |
There was a problem hiding this comment.
Suggested change
| msg := fmt.Sprintf("found mismatching realSize %v reported by backing image manager %v in disk %v, the realSoze recorded in status is %v", | |
| msg := fmt.Sprintf("found mismatching realSize %v reported by backing image manager %v in disk %v, the realSize recorded in status is %v", |
ref: longhorn/longhonr 8757 Signed-off-by: Jack Lin <jack.lin@suse.com>
derekbit
force-pushed
the
LH8757_record_backing_image_real_size
branch
from
6a00d8f
to
7f7861b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#8757
realsizeof backingimage in statusrealsizetostorageScheduledin diskStatusscheduledBackingImagein diskStatus